Skip to content

feat(auth): Add IAlternativeLoginProvider#59627

Merged
CarlSchwan merged 1 commit intomasterfrom
carl/alternative-login-provider
Apr 14, 2026
Merged

feat(auth): Add IAlternativeLoginProvider#59627
CarlSchwan merged 1 commit intomasterfrom
carl/alternative-login-provider

Conversation

@CarlSchwan
Copy link
Copy Markdown
Member

IAlternativeLogin has a fatal flaw in that it is not possible to register multiple alternative login dynamically but only statically.

IAlternativeLoginProvider fixes this limitation as the provider can then provider multiple IAlternativeLogin.

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Apr 14, 2026
@CarlSchwan CarlSchwan added this to the Nextcloud 34 milestone Apr 14, 2026
@CarlSchwan CarlSchwan self-assigned this Apr 14, 2026
@CarlSchwan CarlSchwan force-pushed the carl/alternative-login-provider branch from 1c8210a to fc7648a Compare April 14, 2026 14:15
@CarlSchwan CarlSchwan marked this pull request as ready for review April 14, 2026 14:51
@CarlSchwan CarlSchwan requested a review from a team as a code owner April 14, 2026 14:51
@CarlSchwan CarlSchwan requested review from artonge, nfebe, provokateurin and salmart-dev and removed request for a team April 14, 2026 14:51
IAlternativeLogin has a fatal flaw in that it is not possible to
register multiple alternative login dynamically but only statically.

IAlternativeLoginProvider fixes this limitation as the provider can then
provider multiple IAlternativeLogin.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan force-pushed the carl/alternative-login-provider branch from 2004e7a to f4cae8c Compare April 14, 2026 18:22
@CarlSchwan CarlSchwan enabled auto-merge April 14, 2026 23:32
@CarlSchwan CarlSchwan merged commit dfadafc into master Apr 14, 2026
210 of 219 checks passed
@CarlSchwan CarlSchwan deleted the carl/alternative-login-provider branch April 14, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants